Skip to content

Update visitor function to visit temporal system nexus payloads - #297

Merged
chrsmith merged 1 commit into
mainfrom
spk/sne-visitor-updates
Aug 31, 2026
Merged

Update visitor function to visit temporal system nexus payloads#297
chrsmith merged 1 commit into
mainfrom
spk/sne-visitor-updates

Conversation

@spkane31

Copy link
Copy Markdown
Contributor

What changed?

  • Added generic support for marked system payload envelopes in proxy.VisitPayloads.
  • Introduced the reserved metadata key __temporal_system_payload.
  • When the marker is "true", the visitor decodes the binary protobuf envelope using messageType, visits nested user payloads, and reserializes it without passing the outer envelope to the caller’s codec visitor.
  • Added test coverage.

Why?
Handling system nexus messages based on explicit payload metadata makes traversal generic and avoids service, endpoint, operation, or event-correlation registries.

How did you test it?

  • Added unit tests confirming nested Payload and Payloads mutations survive envelope re-serialization.
  • Added tests for missing/unknown messageType and unsupported encoding.
  • Added a WorkflowService gRPC test covering outbound workflow-task completion and inbound workflow-task polling, verifying only nested payloads reach codec visitors.

@spkane31
spkane31 requested review from a team as code owners July 20, 2026 17:26
@spkane31
spkane31 requested a review from tconley1428 July 20, 2026 19:13
@chrsmith

Copy link
Copy Markdown
Contributor

I'll be rebasing and merging this now that Sean has sadly turned into a force spirit.

@chrsmith
chrsmith force-pushed the spk/sne-visitor-updates branch from 4847236 to b2007cc Compare August 31, 2026 20:36
@chrsmith

Copy link
Copy Markdown
Contributor

I've rebased on top of main, and took a careful look. Given that it already had 3x approvals, I'll just merge this in.

@chrsmith
chrsmith enabled auto-merge (squash) August 31, 2026 20:54
@chrsmith
chrsmith force-pushed the spk/sne-visitor-updates branch from b2007cc to 898a022 Compare August 31, 2026 20:55
@chrsmith
chrsmith merged commit f1ab20a into main Aug 31, 2026
4 checks passed
@chrsmith
chrsmith deleted the spk/sne-visitor-updates branch August 31, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants