Skip to content

refactor(view): improve escaping, null handling, and error cases #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xHeaven wants to merge 18 commits into
base: 3.x
Choose a base branch
from
Open

refactor(view): improve escaping, null handling, and error cases #1781

xHeaven wants to merge 18 commits into from

Conversation

@xHeaven
Copy link
Contributor

@xHeaven xHeaven commented Dec 3, 2025

No description provided.

innocenzi
innocenzi requested changes Dec 3, 2025
View reviewed changes
xHeaven and others added 13 commits December 5, 2025 13:07
@xHeaven
fix(core): gracefully handle missing seeders when using db:seed (te…
0f63187 
…mpestphp#1759)
@xHeaven
fix(auth): pass scopes/options to auth URL builder (tempestphp#1750)
6dcb56f
@xHeaven
fix(auth): update outdated authenticatable import (tempestphp#1752)
cebe571
@xHeaven
refactor(auth): remove double base url call (tempestphp#1753)
d99ded0
@xHeaven
feat(cache): make assertLocked ensure that the checked lock has an …
b80308e 
…expiration (tempestphp#1758)
@xHeaven
fix(cache): add descriptions to cache:clear arguments (tempestphp#1755
6877cd2 
)
@xHeaven @innocenzi
refactor(cache): several fixes and improvements for the cache package (…
974e7bf 
…tempestphp#1760)

Co-authored-by: Enzo Innocenzi <enzo@innocenzi.dev>
@xHeaven
fix(view): correct ArrayAccess::offsetExists in TokenCollection
3771463
@xHeaven
fix(view): handle invalid base64 in Slot content getter
a3300e2
@xHeaven
fix(view): add missing sprintf placeholder for scoped variables
9e594a8
@xHeaven
fix(view): use ENT_QUOTES flag in escape method
27cc963
@xHeaven
fix(view): correct null handling in parser scope property
30ed8eb
@xHeaven
refactor(view): use named parameters
f999b24
@brendt
Copy link
Member

brendt commented Dec 12, 2025

This PR includes PHP 8.5 changes, but we already have those prepared in 3.x: https://github.com/tempestphp/tempest-framework/tree/3.x

Can you make a new version of the PR without 8.5 support?

@brendt brendt closed this Dec 12, 2025
@xHeaven
Copy link
Contributor Author

xHeaven commented Dec 12, 2025 •
edited
Loading

This PR includes PHP 8.5 changes, but we already have those prepared in 3.x: https://github.com/tempestphp/tempest-framework/tree/3.x

Can you make a new version of the PR without 8.5 support?

I feel dumb, but it was requested above to rebase this PR on the 3.0 branch so that I can use array_last() in my last commit 👀 @brendt
Perhaps we could just change the target branch?

@brendt brendt reopened this Dec 12, 2025
@brendt brendt changed the base branch from main to 3.x December 12, 2025 09:33
alamagus
alamagus reviewed Dec 17, 2025
View reviewed changes
alamagus
alamagus reviewed Dec 17, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendt brendt brendt left review comments

@innocenzi innocenzi innocenzi requested changes

+1 more reviewer

@alamagus alamagus alamagus left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xHeaven @brendt @alamagus @innocenzi