ci(coverage): include pkg/apis in Codecov coverage tracking#3686
Open
jkhelil wants to merge 1 commit into
Open
ci(coverage): include pkg/apis in Codecov coverage tracking#3686jkhelil wants to merge 1 commit into
jkhelil wants to merge 1 commit into
Conversation
pkg/apis contains 38 handwritten test files covering validation, lifecycle, and defaults logic — it should not be excluded. Only pkg/client is excluded as it is entirely generated code with no test files. The single generated file in pkg/apis (zz_generated.deepcopy.go) is already excluded by the existing **/zz_generated*.go pattern. Signed-off-by: Jawed khelil <jkhelil@redhat.com> Assisted-by: Claude Sonnet 4.6 (via Cursor) Co-authored-by: Cursor <cursoragent@cursor.com>
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/XS
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3686 +/- ##
=======================================
Coverage 24.49% 24.49%
=======================================
Files 470 470
Lines 24919 24919
=======================================
Hits 6103 6103
Misses 18122 18122
Partials 694 694
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdemeester
approved these changes
Jul 8, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix a missed exclusion from the Codecov configuration added in #3684.
pkg/apis/was incorrectly excluded from coverage tracking. Unlikepkg/client/(which is entirely generated),pkg/apis/contains 38handwritten test files covering validation, lifecycle, and defaults
logic — all of which should be tracked.
What changes:
pkg/apis/**from the.codecov.yamlignore listpkg/client/**excluded (0 test files, 100% generated code)pkg/apis/(zz_generated.deepcopy.go)remains excluded via the existing
**/zz_generated*.gopatternSubmitter Checklist
make test lintbefore submitting a PRRelease Notes
Made with Cursor