Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,3 +120,5 @@ console.log(parsed.get('a number', 'number')); // 987
// coersion will be permissive in its type coersion
console.log(parsed.get('a number', 'boolean')); // true
```

`get(key, 'boolean')` gives `false` for `false`, `no` and `0`, in any case and with any surrounding whitespace, and for an empty value. Any other value gives `true`. `get(key, 'number')` uses `parseInt()`. For an empty value, `toSchema()` uses the schema default instead (see [Custom schemas](#custom-schemas)).
7 changes: 5 additions & 2 deletions src/connection-string.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,11 @@ export class ConnectionString implements ReadonlyMap<string, string> {
return val as CoerceTypeMap[T];
}
switch (actualType) {
case 'boolean':
return (['false', 'no', '0'].includes(val.toLowerCase()) ? false : !!val) as CoerceTypeMap[T];
case 'boolean': {
// a quoted value keeps its surrounding whitespace, so trim it before the match, as SqlClient does
const bool = val.trim().toLowerCase();
return (['false', 'no', '0'].includes(bool) ? false : !!bool) as CoerceTypeMap[T];
}
case 'number':
return parseInt(val, 10) as CoerceTypeMap[T];
default:
Expand Down
10 changes: 10 additions & 0 deletions test/connection-string.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,16 @@ describe('connection-string', () => {
assert.equal(parsed.get('is0', 'boolean'), false);
assert.equal(parsed.get('is1', 'boolean'), true);
});
it('trims a boolean value before coercing it', () => {
const parsed = new ConnectionString('a={ false };b=" no ";c=\' 0\';d={\tFALSE\t};e={ true };f=" yes ";g={ }');
assert.equal(parsed.get('a', 'boolean'), false);
assert.equal(parsed.get('b', 'boolean'), false);
assert.equal(parsed.get('c', 'boolean'), false);
assert.equal(parsed.get('d', 'boolean'), false);
assert.equal(parsed.get('e', 'boolean'), true);
assert.equal(parsed.get('f', 'boolean'), true);
assert.equal(parsed.get('g', 'boolean'), false);
});
it('returns undefined for missing value', () => {
const parsed = new ConnectionString(connectionString);
assert.equal(parsed.get('missing'), undefined);
Expand Down
10 changes: 10 additions & 0 deletions test/parser/fixture/sql-strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,16 @@
}
}
},
{
"name": "trims quoted boolean values",
"connection_string": "Server=h;TrustServerCertificate={ no };MultiSubnetFailover=\" false \";Encrypt=' yes '",
"expected": {
"data source": "h",
"trustservercertificate": false,
"multisubnetfailover": false,
"encrypt": true
}
},
{
"name": "uses the default for an empty boolean or number value",
"connection_string": "Server=h;TrustServerCertificate=;Connect Timeout=;Database=d",
Expand Down