Skip to content

Ignore warnings about float to int casting on tcpdf_fonts #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renanrodrigo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ignore warnings about float to int casting on tcpdf_fonts #857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions include/tcpdf_fonts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@
* @version 1.1.1
* @author Nicola Asuni - info@tecnick.com
*/

// Suppress warning about casting on armhf
set_error_handler(function($errno, $errstr) {
Copy link
Contributor

@williamdes williamdes Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I was not expecting such a patch
it does not fix it but hides the warning
I guess some debuting is needed to fix it for real?
Or this error suppression could be done around the problematic lines?

Copy link
Author

@renanrodrigo renanrodrigo Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well yep.
This is ignoring the error just for the sake of the Ubuntu transition to PHP8.5, so we are not blocked, but the bug is still there - and it was there before, PHP is just complaining about it now...

I fear I don't have enough context to have a good solution for this issue soon, but I can look further in the future.

One thing I ended up doing for other packages is limiting it to 32bit PHP (by wrapping it in a check on PHP_INT_SIZE)

return strpos($errstr, 'is not representable as an int') !== false;
}, E_WARNING);
Copy link
Contributor

@williamdes williamdes Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from that, I would prefer not to keep a diff in Ubuntu
can you send your patch in Debian salsa?
so you can sync the version afterwards

Copy link
Author

@renanrodrigo renanrodrigo Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing: once we agree on a good patch I can send it in salsa too (:


class TCPDF_FONTS {

/**
Expand Down