Repository navigation
fix(mcp): authenticate HTTP clients and separate execution from approval - #49
Merged
Merged
Conversation
teckedd-code2save
marked this pull request as ready for review
September 16, 2026 15:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convoy HTTP accepted unauthenticated requests and reused a stateless transport across calls, breaking repeated requests. MCP-generated GHCR configuration also persisted raw credentials.
This patch creates an authenticated server/transport per HTTP request, binds to loopback by default, and separates read, execution, and approval credentials. Execution cannot approve its own gates. Unsafe remote local-process rehearsal and direct rollback remain disabled until isolated execution and run-bound approval are implemented. New GHCR configuration stores a credential reference; child processes receive a filtered environment without reloading MCP secrets from .env.
Validation: 62 tests pass with node --import tsx --test 'src/**/*.test.ts', including real HTTP requests, repeated/concurrent role isolation, credential revocation, denied approvals, and secret-reference handling. npm run typecheck passes. The normal npm test launcher encountered a workspace Unix-socket restriction; the same tests passed through the direct Node runner.
Not deployed. HTTP supports one trusted workspace, not project/tenant isolation. Existing local stdio behavior remains available. External-reasoning injection, an isolated rehearsal worker, and two-client live acceptance remain open. Updated setup and limits are in docs/mcp.md.