fix(doctor): exclude previous doctor-results archives from new archive#10372
Open
davidfirst wants to merge 2 commits into
Open
fix(doctor): exclude previous doctor-results archives from new archive#10372davidfirst wants to merge 2 commits into
davidfirst wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes bit doctor --archive so repeated runs don’t accidentally include previously generated doctor-results-<timestamp>.tar(.gz) archives inside the newly created archive.
Changes:
- Add a
doctor-results-<digits>.tar(.gz)?filename pattern and filter matching files from the archived workspace. - Normalize ignored file checks using
path.basename()before applying the new archive-name filter.
GiladShoham
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
bit doctor -amultiple times, the second run was including the archive created by the first run. Now theignorefunction filters out any file matching the defaultdoctor-results-<timestamp>.tar(.gz)?pattern, so stale archives are skipped automatically.