fix(scope): validate object refs in /scope/fetch#10371
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens /scope/fetch for type: 'object' by validating raw object refs before converting them to repository Ref instances, aligning object fetch behavior with the existing validation used by component and lane fetches.
Changes:
- Imports
isHashfrom@teambit/component-version. - Validates each object id before constructing
Ref. - Rejects malformed object refs with a clear error.
GiladShoham
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/scope/fetchwithtype: 'object'was passing user-suppliedidsdirectly intonew Ref(id)without format validation. The other fetch types already validate viaComponentID.fromStringorLaneId.parse; this brings theobjecttype in line.Validates each id with
isHash(3–40 hex chars, so short-hash lookups still work) before constructing theRef.