ci: pin actions-hub/kubectl to a full commit SHA#3581
Open
kobihikri wants to merge 1 commit into
Open
Conversation
The preview deploy/cleanup jobs pass a full Kubernetes kubeconfig (secrets.KUBE_CONFIG) to actions-hub/kubectl, which is referenced by the mutable @master tag (manual-preview.yml x3, preview-cleanup.yml x1). Pin it to the current master commit SHA so a moved tag can't run unreviewed code with cluster credentials in scope. Behaviour unchanged; per GitHub's pin-to-SHA guidance. Signed-off-by: Kobi Hikri <kobi.hikri@gmail.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin
actions-hub/kubectl@master→0456ef3…inmanual-preview.yml(×3) andpreview-cleanup.yml(tag kept in a comment).
Why
These deploy/cleanup steps set
KUBE_CONFIG: ${{ secrets.KUBE_CONFIG }}— a full Kubernetes kubeconfig— in the environment of a third-party action pinned to the moving
@masterref. If that action'smasterwere moved (compromise or an accidental change), the new code would run in the runner withcluster credentials present — the class of issue behind the 2025
tj-actions/changed-filesincident,here with Kubernetes cluster access. Pinning to a SHA removes that.
Scope / safety
Behaviour unchanged (SHA = current tip of master). Signed-off. Per GitHub's pin-to-SHA guidance.
AI-assisted; I verified the workflows, the KUBE_CONFIG exposure, and the pinned SHA myself.