Repository navigation
mailserver: persist the mail-ingest login password - #30
Merged
Merged
Conversation
generate_secrets only fills an in-memory map; mailserver's secrets.sh never wrote it back, so MAIL_INGEST_SMTP_PASSWORD would be regenerated and lost on every run and mail-ingest's compose would refuse to start. The existing mail passwords live in .env.global, which only `corekit init` writes. Write the key to the service .env when it is missing, and list it in .env.example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #29.
generate_secretsonly fills an in-memory map, and mailserver'ssecrets.shnever wrote it back. SoMAIL_INGEST_SMTP_PASSWORDwould never reach.env, and mail-ingest's compose would stop on its:?guard. The existing mail passwords live in.env.global, which onlycorekit initwrites.This writes the key to the service
.envwhen it's missing, usingupdate_env_var, and lists it in.env.example.Tested on a disposable copy of the service directory: it writes a 32-character alphanumeric value once, a second run leaves the file unchanged, and other keys are untouched.