Make pointer<T[]> trivially copyable - #9
Merged
Conversation
By giving `slice<T>` defaulted but private copy and assignment (rather than deleted as before) we can in turn default `pointer<T[]>` copy and assignment operators. The result is that `slice` is still non-copyable and non-movable by external code (as we'd like) but now all specialisations of `pointer` are trivially copyable.
`checked_iterator` is three pointers in size, so it's probably better to take it by reference rather than by value in function arguments (if indeed an actual function call is ever generated for these comparison operators...)
We want to make triply sure that `operator==` returns the same thing as `operator<=>`, even though it always would do already in practise...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By giving
slice<T>defaulted but private copy and assignment (rather than deleted as before) we can in turn defaultpointer<T[]>copy and assignment operators.The result is that
sliceis still non-copyable and non-movable by external code (as we'd like) but now all specialisations ofpointerare trivially copyable.