Skip to content

fix: getattr side effects on dependencies implementing __getattr__ #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miragecentury wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: getattr side effects on dependencies implementing __getattr__ #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions taskiq_dependencies/ctx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def resolver(self, executed_func: Any, initial_cache: Dict[Any, Any]) -> Any:

:return: dict with resolved kwargs.
"""
if getattr(executed_func, "dep_graph", False):
if inspect.getattr_static(executed_func, "dep_graph", False):
ctx = SyncResolveContext(executed_func, self.main_graph, initial_cache)
self.sub_contexts.append(ctx)
sub_result = ctx.resolve_kwargs()
Expand Down Expand Up @@ -331,7 +331,7 @@ async def resolver(
:param initial_cache: cache to build a context if graph was passed.
:return: dict with resolved kwargs.
"""
if getattr(executed_func, "dep_graph", False):
if inspect.getattr_static(executed_func, "dep_graph", False):
ctx = AsyncResolveContext(executed_func, self.main_graph, initial_cache) # type: ignore
self.sub_contexts.append(ctx)
sub_result = await ctx.resolve_kwargs()
Expand Down