Skip to content

fix(review): CommentReview redeclares checklist bindings instead of reassigning #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taras merged 1 commit into from
Jul 18, 2026
+5 −2
Merged

fix(review): CommentReview redeclares checklist bindings instead of reassigning #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .reviews/components/CommentReview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,11 @@ for (const pf of pendingFindings) {
});
}

hasChecklist = checklistItems.length > 0;
checklistMd = checklistItems.map(item => {
// Redeclared, not reassigned: bindings from earlier eval blocks arrive in
// later blocks as consts, so assignment throws. A fresh declaration shadows
// the injected binding and its export overrides env for the <Show> below.
const hasChecklist = checklistItems.length > 0;
const checklistMd = checklistItems.map(item => {
const checked = item.status !== "pending" ? "x" : " ";
if (item.status === "applied") {
return `- [${checked}] \`${item.file}:${item.lineNumber}\` (removed)`;
Expand Down
Loading