fix(wasm): make whole vendored tailscale tree writable before patching#567
Merged
Conversation
Since c8b1a30 the tailscale-derp-port.patch now also modifies net/netcheck/netcheck.go. Since only vendor/tailscale.com/derp/derphttp was chmod'd writable, the patch was failing again on the read-only vendored file (a regression since previously fixed by c4ac28f). This commit changes the chmod to scope entire vendor-tree, so should future-proof patch from potential future regressions.
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — broadens the chmod scope in the WASM SSH Nix build from just vendor/tailscale.com/derp/derphttp to the entire vendor/tailscale.com tree, so the tailscale-derp-port.patch can modify files anywhere in the vendored Tailscale sources.
- Expand
chmodwritable scope to entire vendored Tailscale tree — the patch now touchesnet/netcheck/netcheck.go, which is outside the previousderp/derphttpscope. Making the whole vendor tree writable during the build phase is harmless and future-proofs against further patch changes.
DeepSeek Pro (free via Pullfrog for OSS) ｜ 𝕏
tale
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since c8b1a30 the
tailscale-derp-port.patchnow also modifiesnet/netcheck/netcheck.go. Since onlyvendor/tailscale.com/derp/derphttpwas chmod'd writable, the patch was failing again on the read-only vendored file (a regression, since previously fixed by c4ac28f).This commit changes the chmod to scope entire vendor-tree, so should future-proof patch from potential future regressions.