Repository navigation
fix: preserve zero-valued neighboring thumb ARIA bounds - #210
Open
feritcemkahraman wants to merge 1 commit into
Open
feritcemkahraman wants to merge 1 commit into
feritcemkahraman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With values [-5, 0, 5] and global limits -10 to 10, the outer thumbs announce an ARIA maximum/minimum of 10/-10 even though the adjacent thumb limits each to 0.
Use nullish fallback for adjacent values so zero remains a valid accessibility bound. Added regressions for both bounds, outer endpoints and allowOverlap.
Validation: both zero-bound regressions failed before the fix; all 17 unit tests, TypeScript, full ESLint and TypeScript package compilation pass, with four additional assertions against the compiled entry point. Windows checkout line endings were normalized locally for lint. The POSIX packaging cleanup wrapper and Playwright browser suite were not run.