Add s390x-unknown-linux-gnu target#20327
Conversation
Signed-off-by: satyamg1620 <Satyam.Gupta.3@ibm.com>
Confidence Score: 5/5Safe to merge — all three changed files follow the exact same patterns as existing platform targets with no functional code changes. Purely additive build/packaging config mirroring existing patterns exactly — no logic changes, no runtime code affected. napi-rs v3 explicitly documents s390x-unknown-linux-gnu as a supported cross-compilation target with --use-napi-cross. No files require special attention. Reviews (2): Last reviewed commit: "Copy s390x binding into its npm package ..." | Re-trigger Greptile |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds npm packaging metadata and optional dependency wiring for the 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: satyamg1620 <Satyam.Gupta.3@ibm.com>
|
@adamwathan @RobinMalfait Can you please review this PR |
Summary
Adds
s390x-unknown-linux-gnu(Linux on IBM Z, big-endian) as a supported platform for@tailwindcss/oxide, so it ships a prebuilt binding like the other Linux targets.The oxide engine is byte-order-correct on big-endian — no code changes were needed, only build/packaging config:
s390x-unknown-linux-gnuinnapi.targets+ add the@tailwindcss/oxide-linux-s390x-gnuoptional dependencycrates/node/npm/linux-s390x-gnusub-packages390x-unknown-linux-gnurow to the release build matrix (cross-compiled via--use-napi-cross, so no s390x runner is required)Test plan
Verified on a native s390x host (RHEL, GCC 11.5, Node 24):
cargo test→ 332 passed, 0 failed (extractors, scanner, glob, utf16)pnpm run --filter @tailwindcss/oxide build:platform→tailwindcss-oxide.linux-s390x-gnu.node