Skip to content

Add s390x-unknown-linux-gnu target#20327

Open
satyamg1620 wants to merge 2 commits into
tailwindlabs:mainfrom
satyamg1620:s390x-fix
Open

Add s390x-unknown-linux-gnu target#20327
satyamg1620 wants to merge 2 commits into
tailwindlabs:mainfrom
satyamg1620:s390x-fix

Conversation

@satyamg1620

Copy link
Copy Markdown

Summary

Adds s390x-unknown-linux-gnu (Linux on IBM Z, big-endian) as a supported platform for @tailwindcss/oxide, so it ships a prebuilt binding like the other Linux targets.

The oxide engine is byte-order-correct on big-endian — no code changes were needed, only build/packaging config:

  • Register s390x-unknown-linux-gnu in napi.targets + add the @tailwindcss/oxide-linux-s390x-gnu optional dependency
  • Add the crates/node/npm/linux-s390x-gnu sub-package
  • Add an s390x-unknown-linux-gnu row to the release build matrix (cross-compiled via --use-napi-cross, so no s390x runner is required)

Test plan

Verified on a native s390x host (RHEL, GCC 11.5, Node 24):

  • cargo test332 passed, 0 failed (extractors, scanner, glob, utf16)
  • Built the native binding with
    pnpm run --filter @tailwindcss/oxide build:platformtailwindcss-oxide.linux-s390x-gnu.node

Signed-off-by: satyamg1620 <Satyam.Gupta.3@ibm.com>
@satyamg1620 satyamg1620 requested a review from a team as a code owner July 14, 2026 06:22
@greptile-apps

greptile-apps Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Safe to merge — all three changed files follow the exact same patterns as existing platform targets with no functional code changes.

Purely additive build/packaging config mirroring existing patterns exactly — no logic changes, no runtime code affected. napi-rs v3 explicitly documents s390x-unknown-linux-gnu as a supported cross-compilation target with --use-napi-cross.

No files require special attention.

Reviews (2): Last reviewed commit: "Copy s390x binding into its npm package ..." | Re-trigger Greptile

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c68c9919-a786-48e7-8a83-8121cc3d557f

📥 Commits

Reviewing files that changed from the base of the PR and between af01dd3 and 525bf54.

📒 Files selected for processing (1)
  • .github/workflows/release.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/release.yml

Walkthrough

Adds npm packaging metadata and optional dependency wiring for the @tailwindcss/oxide-linux-s390x-gnu native module. Extends the N-API target list and release workflow matrix for s390x-unknown-linux-gnu, including target-specific stripping, cross-compilation flags, binutils installation, and artifact staging.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: adding the s390x-unknown-linux-gnu target.
Description check ✅ Passed The description is directly related to the changeset and accurately summarizes the new s390x platform support.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: satyamg1620 <Satyam.Gupta.3@ibm.com>
@satyamg1620

Copy link
Copy Markdown
Author

@adamwathan @RobinMalfait Can you please review this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant