Skip to content

docs: fix role button cursor selector#2494

Open
Sean-Kenneth-Doherty wants to merge 1 commit into
tailwindlabs:mainfrom
Sean-Kenneth-Doherty:codex/fix-button-role-cursor-selector
Open

docs: fix role button cursor selector#2494
Sean-Kenneth-Doherty wants to merge 1 commit into
tailwindlabs:mainfrom
Sean-Kenneth-Doherty:codex/fix-button-role-cursor-selector

Conversation

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

What changed

  • Updated the upgrade guide role="button" cursor example to check aria-disabled="true" instead of :disabled.

Why

Elements using role="button" are often non-form elements, so :disabled does not model their disabled state. The docs already use quoted aria-disabled="true" selectors elsewhere, so this keeps the example aligned with ARIA disabled state styling.

Fixes #2460.

Validation

  • pnpm install --frozen-lockfile
  • pnpm exec prettier --check src/docs/upgrade-guide.mdx
  • git diff --check
  • pnpm exec eslint src/docs/upgrade-guide.mdx (passes with the repo config ignoring this MDX file)
  • SHARP_IGNORE_GLOBAL_LIBVIPS=1 pnpm run build

Note: pnpm run lint currently reports unrelated repo-wide ESLint errors outside this MDX change.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 17, 2026

@Sean-Kenneth-Doherty is attempting to deploy a commit to the Tailwind Labs Team on Vercel.

A member of the Team first needs to authorize it.

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty marked this pull request as ready for review May 17, 2026 05:06
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Upgrade guide > Buttons use the default cursor" uses incorrect CSS selector

1 participant