android: migrate agp to 9.4 - #865
Merged
Merged
Conversation
hiimtmac
added this pull request to stack #863
September 11, 2026 20:36
hiimtmac
force-pushed
the
hiimtmac/agp-upgrade
branch
from
September 11, 2026 20:41
3a68105 to
33675c6
Compare
hiimtmac
requested review from
barnstar and
kari-ts
and removed request for
barnstar
September 11, 2026 20:42
hiimtmac
removed this pull request from stack #863
September 12, 2026 02:54
hiimtmac
added this pull request to stack #868
September 12, 2026 02:57
hiimtmac
force-pushed
the
hiimtmac/agp-upgrade
branch
from
September 12, 2026 03:00
33675c6 to
4283c1e
Compare
hiimtmac
force-pushed
the
hiimtmac/agp-upgrade
branch
2 times, most recently
from
September 12, 2026 18:46
963af9b to
34b4043
Compare
barnstar
previously requested changes
Sep 14, 2026
hiimtmac
force-pushed
the
hiimtmac/agp-upgrade
branch
from
September 14, 2026 13:44
34b4043 to
e966b64
Compare
hiimtmac
force-pushed
the
hiimtmac/agp-upgrade
branch
from
September 14, 2026 14:28
e966b64 to
40459cc
Compare
kari-ts
reviewed
Sep 14, 2026
| @@ -4,3 +4,8 @@ android.nonFinalResIds=false | |||
| android.nonTransitiveRClass=true | |||
| android.useAndroidX=true | |||
| org.gradle.jvmargs=-Xmx2g -XX:MaxMetaspaceSize=512m | |||
Collaborator
There was a problem hiding this comment.
Iiuc, these are added to preserve existing behavior. do we want to follow up and remove these so we eventually adopt agp 9 defaults wehre possible?
Contributor
Author
There was a problem hiding this comment.
Yep thats correct. These preserve the previous behaviour where defaults changed in AGP 9. I think we should follow up and remove them where possible to adopt the AGP 9 default values. The followups should validate the flags independently especially the two R8 settings against a minified release build. R8 changes are scary 😅
Collaborator
There was a problem hiding this comment.
agreed, sounds good to me!
hiimtmac
force-pushed
the
hiimtmac/agp-upgrade
branch
from
September 14, 2026 17:54
40459cc to
9e36c68
Compare
hiimtmac
force-pushed
the
hiimtmac/agp-upgrade
branch
from
September 14, 2026 18:31
9e36c68 to
73c1801
Compare
Fixes tailscale/corp#48155 Signed-off-by: Taylor McIntyre <taylorm@tailscale.com>
hiimtmac
force-pushed
the
hiimtmac/agp-upgrade
branch
from
September 15, 2026 16:57
73c1801 to
23089f7
Compare
kari-ts
approved these changes
Sep 15, 2026
hiimtmac
dismissed
barnstar’s stale review
September 15, 2026 18:07
Fixed by bumping both docker images
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes tailscale/corp#48155
What changed
jvmTargetconfigurationminSdk,targetSdk, and Java 17 compilationVerification
./gradlew test./gradlew assembleDebug./gradlew assembleRelease./gradlew assembleApplicationTestAndroidTest