Skip to content

android: move to gradle daemon jvm - #864

Open
hiimtmac wants to merge 1 commit into
mainfrom
hiimtmac/gradle-daemon-jvm
Open

hiimtmac wants to merge 1 commit into
mainfrom
hiimtmac/gradle-daemon-jvm

Conversation

@hiimtmac

Copy link
Copy Markdown
Contributor

Fixes tailscale/corp#48153

What changed

  • Declared Java 21 as the required Gradle daemon JVM
  • Added generated daemon JVM criteria for supported platforms
  • Added the Foojay resolver convention for JDK discovery and provisioning

The application continues to compile for Java 17.

Verification

  • Confirmed Gradle runs its daemon on Java 21
  • ./gradlew test
  • ./gradlew assembleDebug
  • ./gradlew assembleRelease
  • ./gradlew assembleApplicationTestAndroidTest

@hiimtmac
hiimtmac added this pull request to stack #863 September 11, 2026 20:32
@hiimtmac
hiimtmac force-pushed the hiimtmac/gradle-daemon-jvm branch from ba43aa6 to ae67741 Compare September 11, 2026 20:40
@hiimtmac
hiimtmac removed this pull request from stack #863 September 12, 2026 02:54
@hiimtmac
hiimtmac added this pull request to stack #868 September 12, 2026 02:57
@hiimtmac
hiimtmac force-pushed the hiimtmac/gradle-daemon-jvm branch from ae67741 to 7bf31cc Compare September 12, 2026 02:58

@bradfitz bradfitz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks run-integration-test.

@hiimtmac
hiimtmac force-pushed the hiimtmac/gradle-daemon-jvm branch from 7bf31cc to a97d783 Compare September 12, 2026 17:39
@hiimtmac
hiimtmac force-pushed the hiimtmac/gradle-daemon-jvm branch from a97d783 to 7f0119d Compare September 14, 2026 13:41
@hiimtmac

Copy link
Copy Markdown
Contributor Author

This breaks run-integration-test.

Thanks for the heads up, problem is fixed in the previous PR (the docker copy of build.gradle needed to be changed to build.gradle.kts)

@hiimtmac
hiimtmac force-pushed the hiimtmac/gradle-daemon-jvm branch from 7f0119d to f2d43c5 Compare September 14, 2026 14:28
@hiimtmac
hiimtmac force-pushed the hiimtmac/gradle-daemon-jvm branch from f2d43c5 to afd2c81 Compare September 14, 2026 17:54
Base automatically changed from hiimtmac/kotlin-gradle-dsl to main September 14, 2026 18:30
Fixes tailscale/corp#48153

Signed-off-by: Taylor McIntyre <taylorm@tailscale.com>
@hiimtmac
hiimtmac force-pushed the hiimtmac/gradle-daemon-jvm branch from afd2c81 to 46153f6 Compare September 14, 2026 18:31
@hiimtmac
hiimtmac requested a review from bradfitz September 14, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants