swift: add public methods for published states and update docs #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Revisions
✅ AI review completed for r4 HelpReact with emojis to give feedback on AI-generated reviews:
We'd love to hear from you—reach out anytime at team@review.ai. |
There was a problem hiding this comment.
Pull Request Overview
This PR exposes previously internal published states as async streams, updates documentation, and adds tests to verify localAPI functionality. Key changes include:
- Updating TailscaleKitTests to safely convert C-style strings to Swift Strings.
- Renaming and exposing connection/listener states via async sequences.
- Refining LocalAPIClient method parameters and documentation.
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| swift/TailscaleKitXCTests/TailscaleKitTests.swift | Enhanced string conversion for controlURL and added tests for localAPI status. |
| swift/TailscaleKit/OutgoingConnection.swift | Corrected a typo in the enum name from "ListenterState" to "ListenerState". |
| swift/TailscaleKit/LocalAPI/LocalAPIClient.swift | Updated parameter naming in editPrefs and improved doc comments. |
| swift/TailscaleKit/Listener.swift | Refactored the published state to _state and added async state stream access. |
| swift/TailscaleKit/IncomingConnection.swift | Refactored published state handling to use async state streams. |
Files not reviewed (2)
- swift/Makefile: Language not supported
- swift/TailscaleKit.xcodeproj/project.pbxproj: Language not supported
ghost
reviewed
May 5, 2025
barnstar
force-pushed
the
barnstar/swift-cleanup
branch
from
8f9fe5d to
31435e6
Compare
ghost
reviewed
May 5, 2025
barnstar
force-pushed
the
barnstar/swift-cleanup
branch
from
31435e6 to
1e5f359
Compare
ghost
reviewed
May 5, 2025
updates tailscale/tailscale#15802 The connection states weren't public. These are now exposed as AsyncSequences so that there's no public dependency on Combine. Documentation cleanup up and clarified slightly. Some minor reorganization of localAPI. Adds a test to ensure that localAPI is functional. Add the xcode equivalent of -wall -werror
barnstar
force-pushed
the
barnstar/swift-cleanup
branch
from
1e5f359 to
4adbbcc
Compare
ghost
reviewed
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates tailscale/tailscale#15802
The @published connection states weren't public. These are now exposed as AsyncSequences
so that there's no public dependency on Combine.
Documentation cleaned up and clarified slightly. Some minor reorganization of localAPI.
Adds a test to ensure that localAPI is functional.
Add the xcode equivalent of -wall -werror