Repository navigation
build!: require Node 22.19 - #116
Merged
Merged
Conversation
Node 20 has been end of life since April 2026, and newer dependencies need a newer floor: undici 8, which the model client is moving to, needs Node 22.19. Raise engines.node to >=22.19 in the root, every package and the examples. CI runs on Node 22.19 and 24. The docs state the new floor, and the reference host drops its own 22.5 note for node:sqlite, which 22.19 covers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Node 20 has been end of life since April 2026, yet SharedOS still declared
>=20.11and tested on it. The model client is moving toundici8, so that a model thinking for more than 5 minutes isn't cut off by the 300 s waits in Node's built-in fetch, andundici8 needs Node 22.19. Core already runs Node 24 everywhere, and releases are built on Node 24.6.0.What
engines.nodeis>=22.19in the root, all 12 packages, and thenetwork-studioandreference-hostexamples. The reference host said 22.5, but its start script passes no--experimental-sqlite, which Node needs before 22.13, so it would have failed on 22.5 to 22.12.release.ymlstays on 24.6.0.No code, test or dependency change: 23 files, 33 lines added and 27 removed.
Related
Merge before
feat/unset-limits(not opened yet). That branch addsundici8 to@aicoo/sharedos-adaptersand is stacked on this commit.Checks
In a plain clone, on Node 22.19.0 and on Node 24.21:
pnpm checkis green on both: format, typecheck, vitest 1155/1155, test:release 7/7,docs:api:checkandconformance:check.pnpm pack:checkandpnpm pack:lintpass on 22.19.node:sqliteloads with no flag.Found while testing, not caused by this PR:
authority.test.ts, "refuses the later of two opens that race under one execution id", fails about 1 run in 50 on main too.openTurnAuthoritygives the lease to whichever load finishes first, and each load hashes on the libuv thread pool, so the later caller can win. Worth its own fix.