fix(ci): trigger on master branch, not nonexistent main - #12
Merged
Conversation
The default branch is master; the push trigger named main, so pushes to the default branch never ran CI. Only the pull_request trigger fired (e.g. during PR #11). Point the push trigger at master so the gate runs on every default- branch push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CI dead-trigger on the default branch.
Root cause:
ci.ymlpushed onbranches: [main], but the repository's default branch ismaster—maindoes not exist. So pushes to the default branch never fired CI; the only runs came from thepull_requesttrigger. After PR #11 merged, master CI has had no trigger at all (verified: no workflow runs on the current master head).Change: the push trigger now names
master— the real default branch — so the gate runs on every default-branch push.Also unblocks the tag-triggered
release.ymlpath: once merged, av0.1.0tag can be pushed on master to publish the Rust binaries as real npm packages (currently only0.0.0-dummy-npmplaceholders exist on npm).