reject format changes while buffers are allocated#53
Open
grawis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject
VIDIOC_S_FMTwithEBUSYwhile videobuf2 buffers are allocated.Previously,
VIDIOC_S_FMTupdateddev->output_formateven when existingbuffers had been allocated using the previous format's
sizeimage. Thiscould leave the current format and buffer sizes inconsistent, causing a
later
VIDIOC_QBUFcall to fail.The change checks
vb2_is_busy()before applying the new format. Applicationsmust release existing buffers with
VIDIOC_REQBUFS count=0before changingthe format.
Test results
Before:
After:
V4L2 compliance:
Total: 50, Succeeded: 50, Failed: 0, Warnings: 0
Fixes #52
Summary by cubic
Reject
VIDIOC_S_FMTwhile videobuf2 buffers are allocated, returning-EBUSY. This keeps the current format consistent with allocated buffer sizes and preventsVIDIOC_QBUFerrors.Applications must release buffers with
VIDIOC_REQBUFS count=0before changing the format.Written for commit 9e4afcd. Summary will update on new commits.