-
Notifications
You must be signed in to change notification settings - Fork 22
Own O_NONBLOCK so a transfer cannot park a vCPU #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jserv
wants to merge
7
commits into
main
Choose a base branch
from
ready-poll
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6167de7
Own O_NONBLOCK so a transfer cannot park a vCPU
jserv dbbe74d
Fix what the PR review found, and two weak proofs
jserv 3aefcb1
Stop a guest pipeline from killing the VM
jserv ac25711
Make the shell half of check-format pass
jserv c775ee4
Stop the synthetic readers parking a vCPU
jserv b5d25f8
Own O_NONBLOCK on sockets, and gather MSG_WAITALL
jserv 54d8291
Fix what the PR review found in the socket work
jserv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -272,13 +272,21 @@ VERIFY_DIRENT_CLAIM := for ANY name length a host or FUSE directory can present | |
| VERIFY_DIRENT_UNPROVED := the readdir walk and the name translation stay test-covered | ||
|
|
||
| VERIFY_IOV_SRC := src/proved/iov.h | ||
| VERIFY_IOV_FCTS := iov_count_ok iov_total_add | ||
| VERIFY_IOV_MIN_GOALS ?= 17 | ||
| VERIFY_IOV_FCTS := iov_count_ok iov_total_add iov_advance_index | ||
| VERIFY_IOV_MIN_GOALS ?= 40 | ||
| VERIFY_IOV_MODEL := typed | ||
| VERIFY_IOV_SCAN := src/proved/iov.h | ||
| VERIFY_IOV_CLAIM := for ANY iovec array a guest can write | ||
| VERIFY_IOV_UNPROVED := the per-entry guest_ptr bounds stay test-covered | ||
|
|
||
| VERIFY_ASYNCUDATA_SRC := src/proved/asyncudata.h | ||
| VERIFY_ASYNCUDATA_FCTS := async_udata_fd async_udata_gen async_udata_pack | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Adding these helpers to the proof set without mutations leaves the new udata packing proof outside the mutation guardrail. Add mutations for the three helpers so regressions in the ABA-field arithmetic are actually rejected. Prompt for AI agents |
||
| VERIFY_ASYNCUDATA_MIN_GOALS ?= 15 | ||
| VERIFY_ASYNCUDATA_MODEL := typed | ||
| VERIFY_ASYNCUDATA_SCAN := src/proved/asyncudata.h | ||
| VERIFY_ASYNCUDATA_CLAIM := for ANY guest fd and slot generation the watcher can arm | ||
| VERIFY_ASYNCUDATA_UNPROVED := the kevent registration and the delivery-side owner checks stay test-covered | ||
|
|
||
| VERIFY_FDSET_SRC := src/proved/fdset.h | ||
| VERIFY_FDSET_FCTS := fdset_words fdset_fd_index fdset_slot | ||
| VERIFY_FDSET_MIN_GOALS ?= 43 | ||
|
|
@@ -336,7 +344,11 @@ commafy = $(subst $(verify_space),$(verify_comma),$(strip $(1))) | |
| # target name is enough and stays readable; a new target using a letter not | ||
| # listed here shows up immediately as a literal upper-case character in the | ||
| # rule name rather than silently misbehaving. | ||
| lc = $(subst A,a,$(subst B,b,$(subst C,c,$(subst D,d,$(subst E,e,$(subst F,f,$(subst G,g,$(subst H,h,$(subst I,i,$(subst K,k,$(subst L,l,$(subst M,m,$(subst N,n,$(subst O,o,$(subst P,p,$(subst Q,q,$(subst R,r,$(subst S,s,$(subst T,t,$(subst U,u,$(subst V,v,$(subst W,w,$(subst X,x,$(1)))))))))))))))))))))))) | ||
| # Lowercase a target name. Spelled out per letter because make has no case | ||
| # function; J, Y and Z were missing from this chain, so a proof target whose | ||
| # name contained one produced a rule nobody could invoke -- silently, since the | ||
| # .PHONY list and the rule name were wrong in the same way. Keep all 26. | ||
| lc = $(subst A,a,$(subst B,b,$(subst C,c,$(subst D,d,$(subst E,e,$(subst F,f,$(subst G,g,$(subst H,h,$(subst I,i,$(subst J,j,$(subst K,k,$(subst L,l,$(subst M,m,$(subst N,n,$(subst O,o,$(subst P,p,$(subst Q,q,$(subst R,r,$(subst S,s,$(subst T,t,$(subst U,u,$(subst V,v,$(subst W,w,$(subst X,x,$(subst Y,y,$(subst Z,z,$(1))))))))))))))))))))))))))) | ||
|
|
||
| # The proof targets, derived rather than listed. Make knows every variable it | ||
| # has read, so the set of VERIFY_<T>_SRC assignments above IS the target list; | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.