Repository navigation
Tell candidates the test sound is optional - #570
Merged
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jserv
reviewed
Nov 2, 2026
jserv
reviewed
Nov 2, 2026
The preflight accepts the candidate's confirmation without a test playback, because the candidate is the only reliable sensor of their own output, yet the Sound step and the status line both read as if playing a sound were required. Say that playing one checks the audio and that clicking "I heard it", the one control that confirms output, is enough when it already works, in the markup, in paintPreflight and in the output message of mediaReadiness, and test that the step text paintPreflight writes matches the markup, so the two cannot drift apart again. Closes sysprog21#359
lakekenny
force-pushed
the
preflight-sound-wording
branch
from
November 2, 2026 07:02
194db2c to
f705240
Compare
Contributor
|
Thank @lakekenny for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The media preflight accepts the candidate's click as confirmation of sound output without a test playback, since the candidate is the only reliable sensor of their own output, but its wording read as if playing a test sound were required. The Sound step now reads 'play a test sound to check your audio, or click "I heard it" if it already works.' in both the markup in
web/interview.htmlandpaintPreflightinweb/interview.js, and the output message ofmediaReadinessinweb/audio-check.jsreads 'Play the test tone or voice to check your audio, or click "I heard it" if it already works.' Both name the button that confirms output, so a candidate who skips the test knows what to press.confirmOutput, click-to-confirm and the othermediaReadinessmessages are unchanged.A test in
tests/browser/audio-check.test.jsrunspaintPreflighton the statemediaReadinessreturns while output is the remaining step, and checks that the Sound step text it writes matches the markup and that the status line shows the new message. It fails if any one of the three texts is changed alone.Closes #359
Summary by cubic
The media preflight accepts the candidate's click as confirmation of sound output without a test playback, but the wording read as if playing a test sound were required. Updates the Sound step and status message to make clear the test is optional.
web/interview.html,paintPreflightinweb/interview.js, and themediaReadinessstatus message inweb/audio-check.jsto "play a test sound ... or click 'I heard it' if it already works."tests/browser/audio-check.test.jsthat confirms the step textpaintPreflightwrites matches the markup and the new status message.Closes #359.
Written for commit f705240. Summary will update on new commits.