Repository navigation
Conversation
The livekit 0.10.0 bump renamed the options type send_text takes from StreamTextOptions to SendTextOptions, which broke the build on every lane. The constructor and setters are unchanged, so the type is renamed at the two sites that name it. The test Recorder now records sender_identity so a test can check a candidate segment is published under the candidate's identity, and the broken-stream board test covers a length mismatch that reaches drain as an error item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The livekit 0.10.0 bump (#567) renamed the options type that LocalParticipant::send_text takes from StreamTextOptions to SendTextOptions, which broke the build on every lane at src/livekit/room_link.rs:160. The constructor and the with_* setters are unchanged, so this renames the type at the two sites that name it.
Behavior on the wire is unchanged. send_text in 0.10 may inline and compress the text, but only when every recipient reports client protocol 2 or newer and advertises deflate-raw. The vendored web/vendor/livekit-client.js reports protocol 1, so the sender keeps the classic stream the browser already reads.
The test Recorder now records sender_identity, which it dropped before, so a test can check that a candidate segment is published under the candidate's identity. A length mismatch on a board stream reaches drain as an error item, and the existing broken-stream test now covers that case.
Summary by cubic
Adopts the
SendTextOptionstype renamed in livekit 0.10.0 so the build passes again —StreamTextOptionsno longer exists, and the constructor and setters are unchanged. Wire behavior is unchanged:send_textmay inline and compress text only when every recipient reports client protocol 2 or newer, and the vendored client reports protocol 1.The test Recorder now records
sender_identity, and a new test checks a candidate segment is published under the candidate's identity. The broken-board-stream test now covers a length mismatch reachingdrainas an error item.Written for commit 1746f1e. Summary will update on new commits.