Skip to content

Adopt livekit 0.10 SendTextOptions - #568

Merged
jserv merged 1 commit into
mainfrom
fix
Nov 1, 2026
Merged

jserv merged 1 commit into
mainfrom
fix

Conversation

@jserv

@jserv jserv commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

The livekit 0.10.0 bump (#567) renamed the options type that LocalParticipant::send_text takes from StreamTextOptions to SendTextOptions, which broke the build on every lane at src/livekit/room_link.rs:160. The constructor and the with_* setters are unchanged, so this renames the type at the two sites that name it.

Behavior on the wire is unchanged. send_text in 0.10 may inline and compress the text, but only when every recipient reports client protocol 2 or newer and advertises deflate-raw. The vendored web/vendor/livekit-client.js reports protocol 1, so the sender keeps the classic stream the browser already reads.

The test Recorder now records sender_identity, which it dropped before, so a test can check that a candidate segment is published under the candidate's identity. A length mismatch on a board stream reaches drain as an error item, and the existing broken-stream test now covers that case.


Summary by cubic

Adopts the SendTextOptions type renamed in livekit 0.10.0 so the build passes again — StreamTextOptions no longer exists, and the constructor and setters are unchanged. Wire behavior is unchanged: send_text may inline and compress text only when every recipient reports client protocol 2 or newer, and the vendored client reports protocol 1.

The test Recorder now records sender_identity, and a new test checks a candidate segment is published under the candidate's identity. The broken-board-stream test now covers a length mismatch reaching drain as an error item.

Written for commit 1746f1e. Summary will update on new commits.

View guided diff Turn on auto-fix

The livekit 0.10.0 bump renamed the options type send_text takes from
StreamTextOptions to SendTextOptions, which broke the build on every
lane. The constructor and setters are unchanged, so the type is renamed
at the two sites that name it. The test Recorder now records
sender_identity so a test can check a candidate segment is published
under the candidate's identity, and the broken-stream board test covers
a length mismatch that reaches drain as an error item.
cubic-dev-ai[bot]

This comment was marked as resolved.

@jserv
jserv merged commit e48811d into main Nov 1, 2026
13 checks passed
@jserv
jserv deleted the fix branch November 1, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant