Add pass-1 all-disk health check to check-bm-server#4
Open
guettli wants to merge 4 commits into
Open
Conversation
Run smartctl -H on every disk visible in rescue (not just rootDeviceHints) during the first pass only, so secondary drives and other attached disks are validated without slowing down the second reliability pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
d5edbfd to
71fc06e
Compare
Run smartctl -H on every disk in rescue (pass 1 only) by enumerating all disk WWNs via GetHardwareDetailsStorage() and reusing CAPH's existing check-disk.sh via ssh.CheckDisk(). Removes the redundant pass-N-check-disk-in-rescue step that only checked rootDeviceHints disks. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
71fc06e to
fa1d225
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a `pass-1-check-all-disks-health` step that checks every disk visible in rescue (not just `rootDeviceHints`) by collecting all disk WWNs via `GetHardwareDetailsStorage()` and passing them to `ssh.CheckDisk()`. Runs in pass 1 only.
Removes the now-redundant `pass-N-check-disk-in-rescue` step — its rootDeviceHints subset is fully covered by the new all-disk check.
Checked with bm-8: