Skip to content

fix: update ldk node for lightning security fixes - #927

Closed
ovitrif wants to merge 2 commits into
release-2.6.0from
fix/ldk-security-rc72-2.6.0
Closed

ovitrif wants to merge 2 commits into
release-2.6.0from
fix/ldk-security-rc72-2.6.0

Conversation

@ovitrif

@ovitrif ovitrif commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator

Refs: synonymdev/ldk-node#123

Description

  • Updates LDK Node from 0.7.0-rc.71 to 0.7.0-rc.72 for the 2.6.0 release, so the shipped node picks up the lightning, lightning-liquidity and lightning-transaction-sync 0.2.7 security fixes.
  • 0.7.0-rc.72 is rc.71 with only those three dependencies updated (release).

Design

N/A — no UI changes.

Preview

N/A — no user-visible changes.

QA Notes

Manual Tests

  • Upgrade from the previous 2.6.0 build with an existing wallet and open channels: the node starts, channels reconnect, balances match.
  • Restore a wallet: on-chain and Lightning balances and activity come back.
  • Send and receive a Lightning payment and an on-chain payment.

Automated Checks

  • xcodebuild -resolvePackageDependencies resolves ldk-node at 0.7.0-rc.72; Package.resolved pins the release tag's commit.

@ovitrif ovitrif added this to the 2.6.0 milestone Oct 13, 2026
@ovitrif ovitrif self-assigned this Oct 13, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T11:55:03.521870Z 2784a0d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ovitrif
ovitrif requested review from a team, ben-kaufman and coreyphillips and removed request for a team October 13, 2026 11:53

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2784a0d249

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CHANGELOG.md Outdated
## [Unreleased]

### Fixed
- Updated LDK Node to 0.7.0-rc.72 for the upstream Lightning security fixes.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Move the release note into a changelog fragment

This normal fix: commit edits CHANGELOG.md directly and adds no corresponding fragment, bypassing the repository's fragment-based release workflow. Move this sentence into exactly one appropriately named file under changelog.d/next/ (likely .security.md or .fixed.md) so release automation can collect and consume it.

AGENTS.md reference: AGENTS.md:L437-L440

Useful? React with 👍 / 👎.

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[High impact] The PR appears safe to merge, with no actionable issues found.

Summary

Updates ldk-node from 0.7.0-rc.71 to 0.7.0-rc.72 for the stated Lightning security fixes.

  • Bitkit builds now use LDK Node 0.7.0-rc.72.

Reviews (1) · Last reviewed commit: "fix: update ldk node for lightning secur..." · Reviewed by Greptile

@ovitrif

ovitrif commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

Closing: per @piotr-iohk, the bump is committed directly on release-2.6.0, so it rides in #925 and CI runs once.

@ovitrif ovitrif closed this Oct 13, 2026
@ovitrif
ovitrif deleted the fix/ldk-security-rc72-2.6.0 branch October 13, 2026 12:11
@ovitrif ovitrif removed this from the 3.0.0 milestone Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant