Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 51f4656821
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ### Fixed | ||
| - Updated LDK Node to 0.7.0-rc.66.1 for the upstream Lightning security fixes. |
There was a problem hiding this comment.
Move the release note to a hotfix fragment
This fix edits CHANGELOG.md directly and adds no fragment, so the 2.5.1 hotfix release process cannot collect and consume the entry from changelog.d/hotfix/; remove this direct edit and add exactly one appropriately named hotfix fragment instead.
AGENTS.md reference: AGENTS.md:L428-L432
Useful? React with 👍 / 👎.
|
|
Closing: per @piotr-iohk, the bump is committed directly on |
Refs: synonymdev/ldk-node#124
Description
0.7.0-rc.66to0.7.0-rc.66.1for the 2.5.1 hotfix, so the shipped node picks up thelightning,lightning-liquidityandlightning-transaction-sync0.2.7 security fixes.0.7.0-rc.66.1is the rc.66 source with only those three dependencies updated, and none of the node changes from rc.67 to rc.71 (release).Design
N/A — no UI changes.
Preview
N/A — no user-visible changes.
QA Notes
Manual Tests
Automated Checks
xcodebuild -resolvePackageDependenciesresolvesldk-nodeat0.7.0-rc.66.1;Package.resolvedpins the release tag's commit.