feat: send paykit payment proofs - #683
Open
ben-kaufman wants to merge 4 commits into
Open
Conversation
2 tasks
This comment has been minimized.
This comment has been minimized.
ben-kaufman
force-pushed
the
codex/paykit-payment-proofs
branch
from
August 24, 2026 18:33
8801387 to
c5d04c7
Compare
ovitrif
reviewed
Aug 25, 2026
ovitrif
left a comment
Collaborator
There was a problem hiding this comment.
On-chain payment proofs cannot recover after a store-load failure, so a successful send can still leave the requester without proof.
ovitrif
approved these changes
Aug 25, 2026
ovitrif
left a comment
Collaborator
There was a problem hiding this comment.
QA Notes
Ran on iPhone 17 Pro simulator and Pixel_9a emulator on regtest.
- iOS created a private request for Android, Android paid, and iOS recorded the proof against that request.
- Android created a private request for iOS, iOS paid, and Android recorded the proof against that request.
Approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sends a Paykit payment proof back to the requester after Bitkit successfully pays an incoming private payment request.
Description
This PR is stacked on #676. Companion Android PR: synonymdev/bitkit-android#1178
Linked Issues/Tasks
N/A
Screenshot / Video
N/A — there are no UI changes.
QA Notes
Manual Tests
Automated Checks
PaykitPaymentProofServiceTests.swift: 8 tests cover restart retry, duplicate suppression, invalid Lightning preimage rejection, failed-payment cleanup, exact on-chain proof submission, overlapping retries, wallet-store clearing, and completed-proof persistence failure.git diff --checkpassed.