Skip to content

chore: bump version 2.4.1 - #678

Open
piotr-iohk wants to merge 6 commits into
masterfrom
release-2.4.1
Open

chore: bump version 2.4.1#678
piotr-iohk wants to merge 6 commits into
masterfrom
release-2.4.1

Conversation

@piotr-iohk

@piotr-iohk piotr-iohk commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Bump version to 2.4.1 (build 196) for release.

This is a hotfix branch cut from v2.4.0, not from master. Do not merge this branch into master. Master already contains these commits plus 2.5.0 work. After store ship, open a small follow-up on master to insert ## [2.4.1], drop consumed changelog.d/next/ fragments, and bump master's version.

Description

  • CURRENT_PROJECT_VERSION: 195 → 196
  • MARKETING_VERSION: 2.4.0 → 2.4.1

Cherry-picked from master

Linked Issues/Tasks

N/A

Screenshot / Video

N/A

Made with Cursor

jvsena42 and others added 6 commits August 21, 2026 08:39
…very

fix: stop auto-accepting stale monitors
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@greptile-apps

greptile-apps Bot commented Aug 21, 2026

Copy link
Copy Markdown

Greptile Summary

This hotfix release advances Bitkit to version 2.4.1 (build 196) and incorporates security hardening from the listed master commits.

  • Pins the VSS client dependency to version 0.5.23.
  • Rejects stale channel-monitor recovery and unauthenticated VSS operation.
  • Preserves pending channel migrations when node setup fails.
  • Restricts shop payment messages and navigation to trusted Bitrefill origins and payment-request types.
  • Adds focused migration, shop-origin, payment-request, and payment-navigation tests.

Confidence Score: 5/5

The reviewed changes appear safe for their intended hotfix release branch, with no actionable defects identified.

The changed security boundaries, migration-consumption lifecycle, lock cleanup, authenticated VSS setup, dependency pin, and release metadata are internally consistent and covered by focused tests.

Important Files Changed

Filename Overview
Bitkit/Components/ShopWebView.swift Adds native sender-origin validation and restricts checkout navigation while leaving non-shop web views unrestricted.
Bitkit/Utilities/ShopOrigin.swift Centralizes trusted Bitrefill host, message-origin, and main-frame navigation policies.
Bitkit/ViewModels/AppViewModel.swift Adds a payment-only scan scope that rejects setup, authentication, gift, and other non-payment payloads before resetting send state.
Bitkit/Services/LightningService.swift Removes stale-monitor auto-acceptance, requires authenticated VSS setup, and releases the process lock when setup fails before creating a node.
Bitkit/Services/MigrationsService.swift Defers deletion of pending channel migration data until the consuming setup operation succeeds.
Bitkit/Services/VssBackupClient.swift Removes the unauthenticated VSS fallback and consistently fails closed when LNURL-auth parameters are unavailable.
Bitkit.xcodeproj/project.pbxproj Advances all relevant targets to version 2.4.1 build 196 and pins vss-rust-client-ffi to 0.5.23.

Sequence Diagram

sequenceDiagram
    participant B as Bitrefill Embed
    participant W as ShopWebView
    participant O as ShopOrigin
    participant A as AppViewModel
    participant P as Payment Sheet
    B->>W: postMessage(payment_intent)
    W->>O: Validate frame and exact origin
    alt Trusted embed origin
        O-->>W: Allow
        W->>A: handleScannedData(paymentRequests)
        A->>A: Decode and validate payment type
        A->>P: Open validated payment request
    else Untrusted origin or request
        O-->>W: Reject
        W-->>B: Ignore or block navigation
    end
Loading

Reviews (1): Last reviewed commit: "chore: version 2.4.1" | Re-trigger Greptile

@piotr-iohk

piotr-iohk commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator Author

@piotr-iohk piotr-iohk self-assigned this Aug 21, 2026
@piotr-iohk
piotr-iohk requested review from ovitrif and pwltr August 21, 2026 08:02
@pwltr

pwltr commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Branch has conflicts with the base branch

@piotr-iohk

Copy link
Copy Markdown
Collaborator Author

Branch has conflicts with the base branch

Expected. This branch was cut from v2.4.0, so it conflicts with master (already on the 2.5.0 train). We are not merging this PR.

The cherry-picked fixes are already on master via their original PRs. After store ship, a small follow-up on master will add ## [2.4.1] to the changelog and bump the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants