test: add hardware wallet e2e on ios#618
Open
piotr-iohk wants to merge 3 commits into
Open
Conversation
Greptile SummaryThis PR adds iOS coverage for hardware wallet E2E flows. The main changes are:
Confidence Score: 4/5The hardware wallet E2E workflow path can fail because the bridge image is pulled but the bridge service is not started.
.github/workflows/e2e-tests.yml
|
| Filename | Overview |
|---|---|
| .github/workflows/e2e-tests.yml | Enables Trezor bridge config and hardware wallet tests, but only pulls the emulator image instead of starting the profiled service. |
| Bitkit/Info.plist | Adds Trezor bridge and electrum plist substitutions for runtime config lookup. |
| Bitkit/Views/Settings/General/HardwareWalletsSettingsScreen.swift | Adds hardware wallet settings accessibility containers and updates row identifiers and tap targets. |
| Bitkit/Views/Sheets/HardwareConnect/HwFoundView.swift | Renames found-state accessibility identifiers and adds a screen accessibility container. |
| Bitkit/Views/Sheets/HardwareConnect/HwPairedView.swift | Adds a screen accessibility container to the paired hardware wallet view. |
| Bitkit/Views/Sheets/HardwareConnect/HwSearchingView.swift | Renames searching-state accessibility identifiers and adds a screen accessibility container. |
| Bitkit/Views/Sheets/HardwareConnectSheet.swift | Renames intro sheet accessibility identifiers and adds a screen accessibility container. |
| Bitkit/Views/Transfer/Hardware/SpendingAmountHw.swift | Adds a hardware transfer amount screen accessibility identifier and container. |
| Bitkit/Views/Transfer/Hardware/SpendingHwSign.swift | Adds a hardware transfer signing screen accessibility identifier and container. |
| Bitkit/Views/Wallets/HardwareWalletScreen.swift | Adds a hardware wallet detail screen accessibility identifier and container. |
Reviews (1): Last reviewed commit: "ci: add hardware wallet e2e to local ios" | Re-trigger Greptile
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1081e125c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #589
This PR:
@hardware_walletspecs into the self-hosted local iOS E2E job (with Trezor emulator image pull), running serially alongside the existing local grep list.Linked Issues/Tasks
Refs #589
Companion PR: synonymdev/bitkit-e2e-tests#195
Screenshot / Video
N/A
QA Notes
Manual Tests
N/A
Automated Checks
actions.tsadds cross-platform id-prefix matching;hardware-wallet.tsfixes rename/delete taps on iOS.@hardware_walletto the existinge2e-tests-localgrep, pulls the Trezor emulator image, and builds withTREZOR_BRIDGE=true/TREZOR_BRIDGE_URL=http://127.0.0.1:21325.BACKEND=local:@hardware_wallet_1,@hardware_wallet_2,@hardware_wallet_3pass.