fix: bump trezor-connect-rs to 0.2.5 (USB I/O serialization)#84
Merged
ben-kaufman merged 2 commits intomasterfrom Apr 1, 2026
Merged
fix: bump trezor-connect-rs to 0.2.5 (USB I/O serialization)#84ben-kaufman merged 2 commits intomasterfrom
ben-kaufman merged 2 commits intomasterfrom
Conversation
Fixes concurrent USB calls interleaving and corrupting the wire protocol,
which caused protobuf decode errors ("invalid tag value: 0"). The upstream
fix adds per-device tokio::sync::Mutex to serialize write/read sequences.
Bumps bitkitcore version 0.1.54 → 0.1.55 and regenerates all bindings.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
ben-kaufman
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trezor-connect-rsfrom 0.2.4 to 0.2.5 (upstream PR)The upstream change adds a
tokio::sync::Mutexper device path to serialize the full write/read sequence. Verified that there are no No API changes that we need to integrate after the update of the dependency.Test plan
cargo test modules::trezor— all 42 tests pass🤖 Generated with Claude Code