chore: improve trezor dashboard#939
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1750d15a1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
082436c to
b49e879
Compare
42b92f7 to
280c4e7
Compare
f71883d to
c224341
Compare
c224341 to
1ecae3d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ecae3dcbc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Description
This PR is intended to address review feedback without changing the Trezor dashboard behavior introduced by #792:
This PR should be validated only against #792.
Preview
testing-3x.mp4
QA Notes
Base comparison:
feat/trezor-hardware-support.feat/trezor-hardware-support-fixes.Official emulator setup:
https://github.com/trezor/trezor-user-env.~/repos/github/trezor-user-envwith./run.sh --no-regtest.docker exec trezor-user-env.mac sh -lc 'apt-get update && apt-get install -y libsdl3-0 libsdl3-image0'.Physical phone install:
adb reverse tcp:21325 tcp:21325TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://127.0.0.1:21325 ./gradlew installDevDebugAndroid emulator install:
TREZOR_BRIDGE=true TREZOR_BRIDGE_URL=http://10.0.2.2:21325 ./gradlew installDevDebugValidation done:
~/repos/github/trezor-user-envand started with./run.sh --no-regtest.websocketsinstalled for controller commands.pingpassed.bridge-startwithnode-bridgepassed.2-mainemulator starts after installinglibsdl3-0andlibsdl3-image0in the container.emulator-setuppassed with the deterministicall all ...seed and labelBitkit Test Trezor.curl -X POST http://localhost:21325/enumeratereturns the official Bridge device:path=1,id=127.0.0.1:21324,apiType=usb.adb reverse tcp:21325 tcp:21325passed on the Pixel 10 Pro test phone../gradlew compileDevDebugKotlin testDevDebugUnitTest detekt --rerun-tasks.Regression checklist against #792:
PR can be approved after code review and light smoke testing, without the need for extensive testing.
The dev validation approach, as described above, involved retesting same functionalities tested in #792 then comparing the results for equality in user-facing functional behavior.