feat(execution-core): emit node_skipped events - #95
Open
dawidaksamski wants to merge 1 commit into
Open
Conversation
dawidaksamski
requested review from
librowski,
lukasz-jazwa,
piotrblaszczyk and
szymon-t-sc
as code owners
August 24, 2026 07:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A pruned branch previously left no trace: the runner marked the node
'skipped'internally and moved on, so a node that never ran was indistinguishable from one the
run hadn't reached yet — in the event stream, in the log panel, and on the canvas.
runGraphnow emits anode_skippedevent for every node whose incoming edges allresolved without a live route, carrying a reason:
reasonbranch_not_takenupstream_skipped'errorRoute'is covered too: a node that fails and routes to its error handle prunesthe success branch, which reports
branch_not_taken.Notable decisions
node_completedand before the next wave'snode_started. Order is a pure functionof the definition, so replay reproduces it.
node
branch_not_taken, tracked in a set rather than read off the last edge toresolve — otherwise a join fed by both a dead branch and a live node that routed
elsewhere would report differently depending on which predecessor resolved last.
emitEventfails the run, same asexecution_started/execution_completed. Unlikenode_startedthere's no nodeexecution to route through an error policy. Flagging in case we'd rather a lost skip
notice never fail an otherwise-good run.
pathIddeliberately left unpopulated — it belongs to the separatedeclared-but-never-emitted contract members question.
AI Studio
Log panel gets a grey badge with the reason inline. Two fixes beyond the planned scope,
both regressions the new status would otherwise have caused: the canvas marker rendered
an empty box for a status none of its branches matched, and highlighting counted skipped
nodes as non-idle, drawing the edge into a pruned branch as if the run had travelled it.