feat(execution-core): require start node - #94
Open
dawidaksamski wants to merge 1 commit into
Open
Conversation
dawidaksamski
requested review from
librowski,
lukasz-jazwa,
piotrblaszczyk and
szymon-t-sc
as code owners
August 24, 2026 07:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The runner inferred entrypoints by counting incoming edges, so any in-degree-0 node was
a root. Delete a node's only edge and it silently became a second entrypoint: it ran in
wave 1 with no upstream context, and its output still flowed downstream. In the
support-triage template that produced a successful run containing a fabricated reply.
The SDK already knows which node is the start, but the kind never reached the backend —
the snapshot schema stripped it.
Now: the react-flow node kind survives validation,
mapNodelifts it to a runner-levelrole: 'start', and a newresolve-start-node.tsresolves the entrypoint before thefirst wave. The runner seeds
readywith that node instead of every in-degree-0 node.Exactly one start, no fallback
The compatibility ramp originally planned here (fall back to in-degree-0 roots when
nothing is declared) was dropped on request. Deliberate consequences:
role: 'start'no longer runs at all — every snapshot reachingthe runner must carry the declaration, i.e. go through the mapper.
DAG scheduler. The
multi-entrypointtest was deleted rather than rewritten, and thetwo asymmetric-fan-in tests now fan out from a single start.
Workflow has no entrypoint nodeis gone; a cycle with no root reports the missingstart instead.
rolelanded as a union rather than a booleanisStart— it takes further roleswithout another field.