Fail the token build on colliding CSS custom property names - #85
Open
librowski wants to merge 1 commit into
Open
Fail the token build on colliding CSS custom property names#85librowski wants to merge 1 commit into
librowski wants to merge 1 commit into
Conversation
librowski
force-pushed
the
ds2-pipeline-prep
branch
from
August 20, 2026 16:48
cf5e471 to
56dbbcf
Compare
librowski
force-pushed
the
ds2-pipeline-prep
branch
2 times, most recently
from
August 20, 2026 17:11
13eda5b to
7009033
Compare
librowski
force-pushed
the
ds2-pipeline-prep
branch
3 times, most recently
from
August 20, 2026 21:53
9f6e5b0 to
cda9005
Compare
librowski
changed the title
librowski
force-pushed
the
ds2-pipeline-prep
branch
4 times, most recently
from
August 20, 2026 23:22
51d25dc to
516bf11
Compare
librowski
marked this pull request as ready for review
August 20, 2026 23:31
librowski
requested review from
lukasz-jazwa,
piotrblaszczyk and
szymon-t-sc
as code owners
August 20, 2026 23:31
…values Style-dictionary's name/kebab flattening can map two distinct token paths to one CSS custom property, and the later definition silently wins. The validator derives names by invoking SD's own name/kebab transform, so the check cannot drift from the build, and aborts on any collision whose values differ.
librowski
force-pushed
the
ds2-pipeline-prep
branch
from
August 21, 2026 00:48
516bf11 to
4d7ec1e
Compare
piotrblaszczyk
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The token build flattens token paths with style-dictionary's
name/kebabtransform; two distinct paths can produce the same CSS custom property name, and the later definition silently wins. The validator derives names with the samechange-casecall the transform uses and fails the build on any collision whose values differ.The DS 2.0 migration tooling (designer changelog, codemod map, usage rewriter) is kept out of the public repo — migration PRs ship only the resulting changes.