Skip to content

Bug[989598] - SfPullToRefresh gets stuck during pulling inside CollectionView, SfListView or SfDataGrid in ios #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
Merged

Bug[989598] - SfPullToRefresh gets stuck during pulling inside CollectionView, SfListView or SfDataGrid in ios #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions maui/src/PullToRefresh/SfPullToRefresh.iOS.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,13 @@ gesture1.Class.Name is not null &&
}
}

#if NET10_0_OR_GREATER && IOS
Copy link

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditional compilation directive only includes IOS, but since this fix is tested on both iOS and macOS (as mentioned in the PR checklist), it should also include MACCATALYST. MacCatalyst apps also use UIKit and would likely experience the same gesture recognition issue on .NET 10.

Consider changing to:

#if NET10_0_OR_GREATER && (IOS || MACCATALYST)

This pattern is consistent with other conditional compilation in the codebase (e.g., Accordion/Helper/AccordionScrollView.cs:9).

Suggested change
#if NET10_0_OR_GREATER && IOS
#if NET10_0_OR_GREATER && (IOS || MACCATALYST)

Copilot uses AI. Check for mistakes.
if (gesture2 is UIPanGestureRecognizer pan2 && pan2.Class != null && pan2.Class.Name != null && pan2.Class.Name.Equals("UIScrollViewPanGestureRecognizer", StringComparison.Ordinal))
{
return true;
}
#endif

return false;
}

Expand Down
Loading