Skip to content

Fix code issues: namespace comment and Windows DLL export #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hobostay wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix code issues: namespace comment and Windows DLL export #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31e946d
Fix incorrect namespace comment placement in example.cpp
Apr 3, 2026
452bd61
Add Windows shared library symbol export support
Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ project(synumpy VERSION 1.9.7 LANGUAGES CXX)

include(GNUInstallDirs)

# Automatically export symbols on Windows when building a shared library
if(WIN32 AND BUILD_SHARED_LIBS)
set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON)
endif()

option(SYNUMPY_BUILD_EXAMPLE "Build the example executable" ON)

add_library(synumpy synumpy.cpp)
Expand Down
4 changes: 2 additions & 2 deletions example.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ void printShape(const syNumpy::NpyArray& array) {
std::cout << array.shape()[i];
}
std::cout << ")\n";
} // namespace
}

template <typename T>
void printValues(const std::vector<T>& values, const char* label) {
Expand All @@ -69,7 +69,7 @@ void printValues(const std::vector<T>& values, const char* label) {
std::cout << "\n";
}

}
} // namespace

int main() {
try {
Expand Down