Fixed the paths of the Monolog config files #9621
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Apr 19, 2018
Contributor
|
@javiereguiluz Aren't new comers going to copy/paste theses files (at least it's what I see in workshops) ? It seems better to me to add them in dev instead of prod. |
xabbuh
reviewed
Apr 20, 2018
| .. code-block:: yaml | ||
| # config/packages/monolog.yaml | ||
| # config/packages/prod/monolog.yaml |
Member
There was a problem hiding this comment.
What about the other formats below?
Member
Author
There was a problem hiding this comment.
Done! Now we need to make a decision about this: keep using prod for the reasons I gave in #9621 (comment) or change it to dev for the reasons given by Hamza in #9621 (comment)
Member
There was a problem hiding this comment.
I would not add them to the dev file I think. It could be too confusing if you do not see all logs anymore during development. But maybe we should add a warning?
javiereguiluz
added a commit
that referenced
this pull request
Apr 27, 2018
This PR was squashed before being merged into the 4.0 branch (closes #9621). Discussion ---------- Fixed the paths of the Monolog config files After reading this comment: #8235 (comment) I realized that some config paths are wrong for Monolog because the recipe (https://github.com/symfony/recipes/tree/master/symfony/monolog-bundle/3.1/config/packages) doesn't create any config file in `config/packages/monolog.yaml` (all files are defined per environment). Most of the examples used `config/packages/prod/monolog.yaml`, so I used that too. It makes sense tome because you usually only carefully configure logs in `prod`. The only article where we maintain `config/packages/dev/monolog.yaml` would be `logging/monolog_console.rst` where I think it makes sense. Commits ------- 9de898a Fixed the paths of the Monolog config files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading this comment: #8235 (comment) I realized that some config paths are wrong for Monolog because the recipe (https://github.com/symfony/recipes/tree/master/symfony/monolog-bundle/3.1/config/packages) doesn't create any config file in
config/packages/monolog.yaml(all files are defined per environment).Most of the examples used
config/packages/prod/monolog.yaml, so I used that too. It makes sense tome because you usually only carefully configure logs inprod. The only article where we maintainconfig/packages/dev/monolog.yamlwould belogging/monolog_console.rstwhere I think it makes sense.