Skip to content

Clean up #8953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Clean up #8953

wants to merge 2 commits into from

Conversation

@carusogabriel
Copy link
Contributor

@carusogabriel carusogabriel commented Jan 1, 2018

Following #8948, suggested by @xabbuh

@carusogabriel
Trailing whitespaces
ff94b14 
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
@carusogabriel
Remove extra lines
386b557 
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
@carusogabriel carusogabriel changed the base branch from master to 4.0 January 1, 2018 15:04
@xabbuh xabbuh added this to the 4.0 milestone Jan 1, 2018
@xabbuh
Copy link
Member

xabbuh commented Jan 1, 2018

Thank you @carusogabriel.

xabbuh added a commit that referenced this pull request Jan 1, 2018
@xabbuh
minor #8953 Clean up (carusogabriel)
70d0f78 
This PR was squashed before being merged into the 4.0 branch (closes #8953).

Discussion
----------

Clean up

Following #8948, suggested by @xabbuh

Commits
-------

ce10e67 Clean up
@xabbuh xabbuh closed this Jan 1, 2018
@xabbuh
Copy link
Member

xabbuh commented Jan 1, 2018

and in master :)

@carusogabriel carusogabriel deleted the clean-up branch January 1, 2018 21:50
@carusogabriel
Copy link
Contributor Author

carusogabriel commented Jan 1, 2018

@xabbuh @wouterj master does not have things to clean up. Thanks for guide me through the branches guys 💯

@xabbuh
Copy link
Member

xabbuh commented Jan 1, 2018

Thank you so much for all the work you did! That's really appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees

No one assigned

Labels

Status: Reviewed

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@carusogabriel @xabbuh @carsonbot