Added tip to enable CsrfTokenManager as service #8941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the framework configuration file as it is required for autowiring on the ExampleFormAuthenticator constructor
Member
javiereguiluz
left a comment
javiereguiluz
left a comment
There was a problem hiding this comment.
I like this but I propose a reword. If #8958 is merged, we'll have a new direct link to the doc of the csrf_protection config option, so we could remove this proposed tip and reword this (line 487):
First, :ref:`add the _csrf_token to your login template <csrf-login-template>`.like this:
First, check that :ref:`the csrf_protection option <reference-framework-csrf-protection>`
is enabled and :ref:`add the _csrf_token to your login template <csrf-login-template>`.
Member
|
Thanks @jonasarts. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 4, 2018
…s, javiereguiluz) This PR was merged into the 4.0 branch. Discussion ---------- Added tip to enable CsrfTokenManager as service in the framework configuration file as it is required for autowiring on the ExampleFormAuthenticator constructor Commits ------- 21d42f3 Reword 9ae3f82 Added tip to enable CsrfTokenManager as service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the framework configuration file as it is required for autowiring on the ExampleFormAuthenticator constructor