Page creation: require profiler with --dev. #8601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Nov 8, 2017
javiereguiluz
approved these changes
Nov 8, 2017
Member
|
You're absolutely right! Thank you Jules! |
weaverryan
added a commit
that referenced
this pull request
Nov 10, 2017
This PR was merged into the master branch. Discussion ---------- Page creation: require profiler with --dev. IMO, it's better to encourage to not have the profiler in production. Commits ------- 38ed1f7 Page creation: require profiler with --dev.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO, it's better to encourage to not have the profiler in production.