[Config][DependencyInjection] Deprecate the fluent PHP format for semantic configuration

Author: nicolas-grekas

CHANGELOG.md

@@ -16,6 +16,7 @@ CHANGELOG
  * Deprecate using `$this` or its internal scope from PHP config files; use the `$loader` variable instead
  * Deprecate XML configuration format, use YAML or PHP instead
  * Deprecate `ExtensionInterface::getXsdValidationBasePath()` and `getNamespace()`
+ * Deprecate the fluent PHP format for semantic configuration, instantiate builders inline with the config array as argument and return them instead
 
 7.3
 ---

Loader/PhpFileLoader.php

@@ -253,6 +253,7 @@ private function callConfigurator(callable $callback, ContainerConfigurator $con
                     } catch (InvalidArgumentException|\LogicException $e) {
                         throw new \InvalidArgumentException(\sprintf('Could not resolve argument "%s" for "%s".', $type.' $'.$parameter->getName(), $path), 0, $e);
                     }
+                    trigger_deprecation('symfony/dependency-injection', '7.4', 'Using fluent builders for semantic configuration is deprecated, instantiate the "%s" class with the config array as argument and return it instead in "%s".', $type, $path);
                     $configBuilders[] = $configBuilder;
                     $arguments[] = $configBuilder;
             }

Tests/Fixtures/config/config_builder_env_configurator.php

@@ -3,6 +3,6 @@
 use Symfony\Component\DependencyInjection\Tests\Fixtures\AcmeConfig;
 use function Symfony\Component\DependencyInjection\Loader\Configurator\env;
 
-return function (AcmeConfig $config) {
-    $config->color(env('COLOR'));
+return function () {
+    return new AcmeConfig(['color' => env('COLOR')]);
 };

Tests/Fixtures/config/env_param.php

@@ -2,10 +2,6 @@
 
 use Symfony\Component\DependencyInjection\Tests\Fixtures\AcmeConfig;
 
-return function (AcmeConfig $config, string $env) {
-    if ('prod' === $env) {
-        $config->color('blue');
-    } else {
-        $config->color('red');
-    }
+return function (string $env) {
+    return new AcmeConfig(['color' => 'prod' === $env ? 'blue' : 'red']);
 };

Tests/Fixtures/config/nested_config_builder.php

@@ -6,6 +6,4 @@
     return;
 }
 
-return function (AcmeConfig $config) {
-    $config->color('red');
-};
+return new AcmeConfig(['color' => 'red']);

Tests/Fixtures/config/return_config_builder.php

@@ -2,7 +2,4 @@
 
 use Symfony\Component\DependencyInjection\Tests\Fixtures\AcmeConfig;
 
-$config = new AcmeConfig();
-$config->color('red');
-
-return $config;
+return new AcmeConfig(['color' => 'red']);

Tests/Loader/PhpFileLoaderTest.php

@@ -251,6 +251,8 @@ public function testEnumeration()
         $this->assertSame([FooUnitEnum::BAR], $definition->getArguments());
     }
 
+    #[IgnoreDeprecations]
+    #[Group('legacy')]
     public function testNestedBundleConfigNotAllowed()
     {
         $fixtures = realpath(__DIR__.'/../Fixtures');