Skip to content

Commit 2ba0863

Browse files
nicolas-grekasnicolas-grekas
committed
[DependencyInjection] Split ImportsConfig and ParametersConfig out of ServicesConfig
1 parent 287e74a commit 2ba0863

File tree

6 files changed

+104
-57
lines changed

6 files changed

+104
-57
lines changed

‎Loader/Config/ImportsConfig.php‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
<?php
2+
3+
/*
4+
* This file is part of the Symfony package.
5+
*
6+
* (c) Fabien Potencier <fabien@symfony.com>
7+
*
8+
* For the full copyright and license information, please view the LICENSE
9+
* file that was distributed with this source code.
10+
*/
11+
12+
namespace Symfony\Config;
13+
14+
/**
15+
* @psalm-type Imports = list<string|array{
16+
* resource: string,
17+
* type?: string|null,
18+
* ignore_errors?: bool,
19+
* }>
20+
*/
21+
class ImportsConfig
22+
{
23+
/**
24+
* @param Imports $config
25+
*/
26+
public function __construct(
27+
public readonly array $config,
28+
) {
29+
}
30+
}

‎Loader/Config/ParametersConfig.php‎

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
<?php
2+
3+
/*
4+
* This file is part of the Symfony package.
5+
*
6+
* (c) Fabien Potencier <fabien@symfony.com>
7+
*
8+
* For the full copyright and license information, please view the LICENSE
9+
* file that was distributed with this source code.
10+
*/
11+
12+
namespace Symfony\Config;
13+
14+
/**
15+
* @psalm-type Parameters = array<string, scalar|\UnitEnum|array<scalar|\UnitEnum|array|null>|null>
16+
*/
17+
class ParametersConfig
18+
{
19+
/**
20+
* @param Parameters $config
21+
*/
22+
public function __construct(
23+
public readonly array $config,
24+
) {
25+
}
26+
}

‎Loader/Config/ServicesConfig.php‎

Lines changed: 9 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
namespace Symfony\Config;
1313

1414
use Symfony\Component\DependencyInjection\ContainerInterface;
15-
use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;
1615
use Symfony\Component\DependencyInjection\Loader\Configurator\ReferenceConfigurator;
1716
use Symfony\Component\DependencyInjection\Reference;
1817
use Symfony\Component\ExpressionLanguage\Expression;
@@ -21,16 +20,10 @@
2120

2221
/**
2322
* @psalm-type Arguments = list<mixed>|array<string, mixed>
24-
* @psalm-type Callback = string|array{0:string|Reference|ReferenceConfigurator,1:string}|\Closure|Reference|ReferenceConfigurator|Expression
23+
* @psalm-type Call = array<string, Arguments>|array{0:string, 1?:Arguments, 2?:bool}|array{method:string, arguments?:Arguments, returns_clone?:bool}
2524
* @psalm-type Tags = list<string|array<string, array<string, mixed>>>
25+
* @psalm-type Callback = string|array{0:string|Reference|ReferenceConfigurator,1:string}|\Closure|Reference|ReferenceConfigurator|Expression
2626
* @psalm-type Deprecation = array{package: string, version: string, message?: string}
27-
* @psalm-type Call = array<string, Arguments>|array{0:string, 1?:Arguments, 2?:bool}|array{method:string, arguments?:Arguments, returns_clone?:bool}
28-
* @psalm-type Imports = list<string|array{
29-
* resource: string,
30-
* type?: string|null,
31-
* ignore_errors?: bool,
32-
* }>
33-
* @psalm-type Parameters = array<string, scalar|\UnitEnum|array<scalar|\UnitEnum|array|null>|null>
3427
* @psalm-type Defaults = array{
3528
* public?: bool,
3629
* tags?: Tags,
@@ -111,32 +104,19 @@
111104
* public?: bool,
112105
* deprecated?: Deprecation,
113106
* }
114-
* @psalm-type Services = array<string, Definition|Alias|Prototype|Stack>|array<class-string, Arguments|null>
107+
* @psalm-type Services = array{
108+
* _defaults?: Defaults,
109+
* _instanceof?: Instanceof,
110+
* ...<string, Definition|Alias|Prototype|Stack|Arguments|null>
111+
* }
115112
*/
116113
class ServicesConfig
117114
{
118-
public readonly array $services;
119-
120115
/**
121-
* @param Services $services
122-
* @param Imports $imports
123-
* @param Parameters $parameters
124-
* @param Defaults $defaults
125-
* @param Instanceof $instanceof
116+
* @param Services $config
126117
*/
127118
public function __construct(
128-
array $services = [],
129-
public readonly array $imports = [],
130-
public readonly array $parameters = [],
131-
array $defaults = [],
132-
array $instanceof = [],
119+
public readonly array $config,
133120
) {
134-
if (isset($services['_defaults']) || isset($services['_instanceof'])) {
135-
throw new InvalidArgumentException('The $services argument should not contain "_defaults" or "_instanceof" keys, use the $defaults and $instanceof parameters instead.');
136-
}
137-
138-
$services['_defaults'] = $defaults;
139-
$services['_instanceof'] = $instanceof;
140-
$this->services = $services;
141121
}
142122
}

‎Loader/PhpFileLoader.php‎

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
use Symfony\Component\DependencyInjection\Extension\ConfigurationExtensionInterface;
2626
use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
2727
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
28+
use Symfony\Config\ImportsConfig;
29+
use Symfony\Config\ParametersConfig;
2830
use Symfony\Config\ServicesConfig;
2931

3032
/**
@@ -97,7 +99,7 @@ public function load(mixed $resource, ?string $type = null): mixed
9799
if (\is_object($result) && \is_callable($result)) {
98100
$result = $this->callConfigurator($result, new ContainerConfigurator($this->container, $this, $this->instanceof, $path, $resource, $this->env), $path);
99101
}
100-
if ($result instanceof ConfigBuilderInterface || $result instanceof ServicesConfig) {
102+
if ($result instanceof ServicesConfig || $result instanceof ParametersConfig || $result instanceof ImportsConfig || $result instanceof ConfigBuilderInterface) {
101103
$result = [$result];
102104
} elseif (!is_iterable($result ?? [])) {
103105
throw new InvalidArgumentException(\sprintf('The return value in config file "%s" is invalid: "%s" given.', $path, get_debug_type($result)));
@@ -108,25 +110,33 @@ public function load(mixed $resource, ?string $type = null): mixed
108110
$config = [$key => $config];
109111
} elseif (!$this->env || 'when@'.$this->env !== $key) {
110112
continue;
111-
} elseif ($config instanceof ServicesConfig || $config instanceof ConfigBuilderInterface) {
113+
} elseif ($config instanceof ServicesConfig || $config instanceof ParametersConfig || $config instanceof ImportsConfig || $config instanceof ConfigBuilderInterface) {
112114
$config = [$config];
113115
} elseif (!is_iterable($config)) {
114116
throw new InvalidArgumentException(\sprintf('The "%s" key should contain an array in "%s".', $key, $path));
115117
}
116118

117119
foreach ($config as $key => $config) {
118-
if ($config instanceof ServicesConfig || \in_array($key, ['imports', 'parameters', 'services'], true)) {
119-
if (!$config instanceof ServicesConfig) {
120+
$expectedKey = match (true) {
121+
$config instanceof ServicesConfig => 'services',
122+
$config instanceof ParametersConfig => 'parameters',
123+
$config instanceof ImportsConfig => 'imports',
124+
default => null,
125+
};
126+
if (null !== $expectedKey || \in_array($key, ['services', 'parameters', 'imports'], true)) {
127+
if (null === $expectedKey) {
120128
$config = [$key => $config];
121-
} elseif (\is_string($key) && 'services' !== $key) {
122-
throw new InvalidArgumentException(\sprintf('Invalid key "%s" returned for the "%s" config builder; none or "services" expected in file "%s".', $key, get_debug_type($config), $path));
129+
} elseif (\is_string($key) && $key !== $expectedKey) {
130+
throw new InvalidArgumentException(\sprintf('Invalid key "%s" returned for the "%s" config builder; none or "%s" expected in file "%s".', $key, get_debug_type($config), $expectedKey, $path));
131+
} else {
132+
$config = [$expectedKey => $config->config];
123133
}
124134
$yamlLoader = new YamlFileLoader($this->container, $this->locator, $this->env, $this->prepend);
125135
$yamlLoader->setResolver(new LoaderResolver([$this]));
126136
$loadContent = new \ReflectionMethod(YamlFileLoader::class, 'loadContent');
127137
++$this->importing;
128138
try {
129-
$loadContent->invoke($yamlLoader, ContainerConfigurator::processValue((array) $config), $path);
139+
$loadContent->invoke($yamlLoader, ContainerConfigurator::processValue($config), $path);
130140
} finally {
131141
--$this->importing;
132142
}
@@ -288,7 +298,7 @@ private function configBuilder(string $namespace): ConfigBuilderInterface
288298
throw new InvalidArgumentException(\sprintf('Could not find or generate class "%s".', $namespace));
289299
}
290300

291-
if (is_a($namespace, ServicesConfig::class, true)) {
301+
if (is_a($namespace, ServicesConfig::class, true) || is_a($namespace, ParametersConfig::class, true) || is_a($namespace, ImportsConfig::class, true)) {
292302
throw new \LogicException(\sprintf('You cannot use "%s" as a config builder; create an instance and return it instead.', $namespace));
293303
}
294304

‎Tests/Fixtures/config/object_array_config.php‎

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,21 @@
11
<?php
22

33
use Symfony\Component\DependencyInjection\Tests\Fixtures\Bar;
4+
use Symfony\Config\ParametersConfig;
45
use Symfony\Config\ServicesConfig;
56

6-
return new ServicesConfig(
7-
parameters: [
7+
return [
8+
new ParametersConfig([
89
'foo' => 'bar',
9-
],
10-
defaults: [
11-
'public' => true,
12-
],
13-
services: [
10+
]),
11+
new ServicesConfig([
12+
'_defaults' => [
13+
'public' => true,
14+
],
1415
Bar::class => null,
1516
'my_service' => [
1617
'class' => Bar::class,
1718
'arguments' => ['%foo%'],
1819
],
19-
]);
20+
]),
21+
];

‎Tests/Fixtures/config/return_when_env.php‎

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,23 @@
11
<?php
22

33
use Symfony\Component\DependencyInjection\Tests\Fixtures\Bar;
4+
use Symfony\Config\ParametersConfig;
45
use Symfony\Config\ServicesConfig;
56

67
return [
78
'when@prod' => [
8-
'parameters' => [
9+
new ParametersConfig([
910
'foo_param' => 'bar_value',
10-
],
11-
new ServicesConfig(
12-
defaults: [
11+
]),
12+
new ServicesConfig([
13+
'_defaults' => [
1314
'public' => true,
1415
],
15-
services: [
16-
Bar::class => null,
17-
'my_service' => [
18-
'class' => Bar::class,
19-
'arguments' => ['%foo_param%'],
20-
],
21-
]
22-
),
16+
Bar::class => null,
17+
'my_service' => [
18+
'class' => Bar::class,
19+
'arguments' => ['%foo_param%'],
20+
],
21+
]),
2322
],
2423
];

0 commit comments

Comments
 (0)