[DependencyInjection][Routing] Fix nested config imports when returning PHP arrays

Author: nicolas-grekas

Loader/PhpFileLoader.php

@@ -15,6 +15,7 @@
 use Symfony\Component\Config\Builder\ConfigBuilderGeneratorInterface;
 use Symfony\Component\Config\Builder\ConfigBuilderInterface;
 use Symfony\Component\Config\FileLocatorInterface;
+use Symfony\Component\Config\Loader\LoaderResolver;
 use Symfony\Component\DependencyInjection\Attribute\When;
 use Symfony\Component\DependencyInjection\Attribute\WhenNot;
 use Symfony\Component\DependencyInjection\Container;
@@ -121,8 +122,14 @@ public function load(mixed $resource, ?string $type = null): mixed
                             throw new InvalidArgumentException(\sprintf('Invalid key "%s" returned for the "%s" config builder; none or "services" expected in file "%s".', $key, get_debug_type($config), $path));
                         }
                         $yamlLoader = new YamlFileLoader($this->container, $this->locator, $this->env, $this->prepend);
+                        $yamlLoader->setResolver(new LoaderResolver([$this]));
                         $loadContent = new \ReflectionMethod(YamlFileLoader::class, 'loadContent');
-                        $loadContent->invoke($yamlLoader, ContainerConfigurator::processValue((array) $config), $path);
+                        ++$this->importing;
+                        try {
+                            $loadContent->invoke($yamlLoader, ContainerConfigurator::processValue((array) $config), $path);
+                        } finally {
+                            --$this->importing;
+                        }
                     } elseif ($config instanceof ConfigBuilderInterface) {
                         if (\is_string($key) && $config->getExtensionAlias() !== $key) {
                             throw new InvalidArgumentException(\sprintf('The extension alias "%s" of the "%s" config builder does not match the key "%s" in file "%s".', $config->getExtensionAlias(), get_debug_type($config), $key, $path));

Tests/Fixtures/config/config_builder.php

@@ -1,14 +1,14 @@
 <?php
 
-use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
 use Symfony\Component\DependencyInjection\Tests\Fixtures\AcmeConfig;
 
 if ('prod' !== $env) {
     return;
 }
 
-return function (AcmeConfig $config, ContainerConfigurator $c) {
-    $c->import('nested_config_builder.php');
-
-    $config->color('blue');
-};
+return [
+    'imports' => [
+        'nested_config_builder.php',
+    ],
+    new AcmeConfig(['color' => 'blue']),
+];

Tests/Loader/PhpFileLoaderTest.php

@@ -68,8 +68,8 @@ public function testPrependExtensionConfigWithLoadMethod()
         $container = new ContainerBuilder();
         $container->registerExtension(new \AcmeExtension());
         $container->prependExtensionConfig('acme', ['foo' => 'bar']);
-        $loader = new PhpFileLoader($container, new FileLocator(\dirname(__DIR__).'/Fixtures'), 'prod', new ConfigBuilderGenerator(sys_get_temp_dir()), true);
-        $loader->load('config/config_builder.php');
+        $loader = new PhpFileLoader($container, new FileLocator(\dirname(__DIR__).'/Fixtures/config'), 'prod', new ConfigBuilderGenerator(sys_get_temp_dir()), true);
+        $loader->load('config_builder.php');
 
         $expected = [
             ['color' => 'red'],
@@ -84,8 +84,8 @@ public function testPrependExtensionConfigWithImportMethod()
         $container = new ContainerBuilder();
         $container->registerExtension(new \AcmeExtension());
         $container->prependExtensionConfig('acme', ['foo' => 'bar']);
-        $loader = new PhpFileLoader($container, new FileLocator(\dirname(__DIR__).'/Fixtures'), 'prod', new ConfigBuilderGenerator(sys_get_temp_dir()), true);
-        $loader->import('config/config_builder.php');
+        $loader = new PhpFileLoader($container, new FileLocator(\dirname(__DIR__).'/Fixtures/config'), 'prod', new ConfigBuilderGenerator(sys_get_temp_dir()), true);
+        $loader->import('config_builder.php');
 
         $expected = [
             ['color' => 'red'],