Support mixed for getContent method
#820
Open
+16
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulinevos
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
carsonbot
changed the title
mixed for getContent methodmixed for getContent method
paulinevos
force-pushed
the
mixed-content
branch
from
3206ead to
6606004
Compare
paulinevos
commented
Oct 27, 2025
paulinevos
commented
Oct 27, 2025
paulinevos
force-pushed
the
mixed-content
branch
2 times, most recently
from
2287f60 to
d3c8093
Compare
chr-hertel
requested changes
Nov 7, 2025
Member
chr-hertel
left a comment
chr-hertel
left a comment
There was a problem hiding this comment.
Sorry for he late response, let's go with string|object here - or do we need array as well?
As the Vectorizer currently makes assumptions about having to pass string data to `PlatformInterface::invoke`, when that method can actually take about any sort of input. `Platform` implementations decide what data types they can handle through their normalizers. Therefore, it should be up to `platform` to handle types and not up to `store` to decide that it should only pass strings.
paulinevos
force-pushed
the
mixed-content
branch
from
d3c8093 to
5a4473b
Compare
chr-hertel
reviewed
Nov 10, 2025
Comment on lines
-21
to
29
|
|
||
| final readonly class Vectorizer implements VectorizerInterface | ||
| final class Vectorizer implements VectorizerInterface | ||
| { | ||
| public function __construct( | ||
| private PlatformInterface $platform, | ||
| private string $model, | ||
| private LoggerInterface $logger = new NullLogger(), | ||
| private readonly PlatformInterface $platform, | ||
| private readonly string $model, | ||
| private readonly LoggerInterface $logger = new NullLogger(), | ||
| ) { | ||
| } |
Member
There was a problem hiding this comment.
a bit confused about this diff, since it is already fixed on main with #829
ai/src/store/src/Document/Vectorizer.php
Lines 21 to 28 in 5f498f5
Contributor
Author
There was a problem hiding this comment.
Yeah weird, I'll try rebase although that shouldn't have any bearing on this diff... Maybe GH being buggy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the Vectorizer currently makes assumptions about having to pass string data to
PlatformInterface::invoke, when that method can actually take about any sort of input.Platformimplementations decide what data types they can handle through their normalizers. Therefore, it should be up toplatformto handle types and not up tostoreto decide that it should only pass strings.