Repository navigation
Fix crash for non-numeric Pyfunction.eval - #532
Merged
Merged
Conversation
alexfikl
force-pushed
the
evalf-symbolic-pyfunction
branch
from
October 6, 2026 11:18
0b76eaa to
2cd76d3
Compare
alexfikl
marked this pull request as ready for review
October 25, 2026 15:02
Contributor
Author
|
The CI is currently failing because the test added here fails without symengine/symengine#2173. What's the workflow for that? Do we wait for a new release of |
Member
|
You can use a commit hash in |
Contributor
Author
Done! Fingers crossed 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The added test case would outright segfault before. This essentially tries to convert to a number and raises
NotImplementedErrorif the expression is symbolic. ThatNotImplementedErroris then caught by symengine/symengine#2173 and the expression is returned as is (which, as far as I know, matchessympy's behavior).Needs: symengine/symengine#2173
xref: inducer/sumpy#306
cc: @inducer