Open
Conversation
Update fable js api interaciton for bundleIcons
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates from Feliz 2.x to Feliz 3.2.0, updating internal APIs
that were removed or changed in Feliz 3.
Feliz 3.x compatibility
Interop.reactApi.Children.toArraywithArray.ofSeqacross Props.fs,Props2.fs, and FelizProps.fs (18 occurrences)
Interop.mkAttr→PropHelper.mkAttrandInterop.mkStyle→StyleHelper.mkStylein the FelizOverloads moduleInterop.reactElementWithChildrenhelper to Utils.fsFix
createElementchildren handlingFuiHelpers.createElementnow extractschildrenfrom props and passes themas spread arguments to
React.createElement, matching how Feliz 3.x handles it.Uses
Feliz.HtmlHelper.extractByKeyFastfor extraction.being passed as an array inside the props object.
reactElementWithChildreninstead ofcreateElementwithprop.children.Fable 5 compatibility
imports with
importAll+emitJsExprdynamic access, since Fable 5 requiresstring literals for
import.Feliz 3.x + fable 4.x had some breaking changes, and required either to add a
NoWarn NU1605, or to upgrade to fable 5 prerelease. Therefore took a long shot and went with Fable 5 since it seems it is maturing.It works perfectly fine with fable 4 as well, if stable fable version is preferred.
Package updates
Interop.reactApi.Children.toArray, usesArray.ofSeq