fix(optimizer): handle internal class literals in get_parent_class - #44
Merged
matyhtf merged 1 commit intoSep 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
get_parent_class()crashes during conversion when a string literal names an internal PHP class:The optimizer assumes every literal class name exists in the compilation symbol table and uses the non-null lookup, so internal classes produce an invalid lookup instead of falling back to runtime resolution.
Fix
Use the nullable class lookup for compile-time folding. Known project classes continue to fold at compile time, while internal class names use
php::fn::get_parent_class().Tests
get_parent_class()PHPT coverage for internal classes with and without parents.